Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some log to print size of search result #27601

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add some log to print size of search result #27601

merged 1 commit into from
Oct 16, 2023

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Oct 10, 2023 •
edited
Loading

/kind improvement
#27520

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. labels Oct 10, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #27601 (8051a5a) into master (82b2edc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27601      +/-   ##
==========================================
+ Coverage   81.51%   81.53%   +0.02%     
==========================================
  Files         805      796       -9     
  Lines      114222   114145      -77     
==========================================
- Hits        93103    93066      -37     
+ Misses      17981    17944      -37     
+ Partials     3138     3135       -3
Files Coverage Δ
internal/core/src/segcore/Reduce.cpp 92.37% <100.00%> (+0.41%) ⬆️
internal/proxy/task_search.go 75.63% <100.00%> (+0.06%) ⬆️

... and 164 files with indirect coverage changes

@smellthemoon smellthemoon force-pushed the add-log branch 2 times, most recently from 8acad20 to 3ffd926 Compare October 11, 2023 07:19
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

3 similar comments
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Oct 13, 2023
congqixia
congqixia approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5785756 into milvus-io:master Oct 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smellthemoon @sre-ci-robot @congqixia