Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine KV errors #27588

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Refine KV errors #27588

merged 1 commit into from
Oct 13, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Oct 10, 2023

/kind improvement
related #27490

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Oct 10, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #27588 (4a66ffc) into master (82b2edc) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #27588   +/-   ##
=======================================
  Coverage   81.51%   81.51%           
=======================================
  Files         805      805           
  Lines      114222   114215    -7     
=======================================
+ Hits        93103    93108    +5     
+ Misses      17981    17970   -11     
+ Partials     3138     3137    -1     
Files Coverage Δ
internal/kv/etcd/embed_etcd_kv.go 83.41% <100.00%> (ø)
internal/kv/mem/mem_kv.go 72.64% <100.00%> (ø)
internal/kv/tikv/txn_tikv.go 83.12% <100.00%> (ø)
internal/metastore/kv/rootcoord/kv_catalog.go 87.61% <100.00%> (ø)
pkg/common/error.go 69.23% <ø> (-10.77%) ⬇️
internal/kv/etcd/etcd_kv.go 81.69% <66.66%> (ø)
internal/rootcoord/root_coord.go 90.01% <66.66%> (ø)

... and 21 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 12, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: yah01 <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 13, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Oct 13, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 13, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 15746b5 into milvus-io:master Oct 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants