Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ann Benchmark threw error running SIFT #27417

Closed
1 task done
pauldintel opened this issue Sep 27, 2023 · 14 comments
Closed
1 task done

Ann Benchmark threw error running SIFT #27417

pauldintel opened this issue Sep 27, 2023 · 14 comments
Assignees
Labels
help wanted Extra attention is needed kind/bug Issues or changes related a bug stale indicates no udpates for 30 days

Comments

@pauldintel
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 2.3.1
- Deployment mode(standalone or cluster): Standalone
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2): pymilvus
- OS(Ubuntu or CentOS): Ubuntu 22.04
- CPU/Memory: 16 vCPU, 64GB
- GPU: 
- Others:

Current Behavior

While running ANN benchmark ended up with error :
:~/ann-benchmarks$ sudo python3 run.py --dataset sift-128-euclidean --algorithm milvus --local
2023-09-27 22:15:01,502 - annb - INFO - running only milvus
Traceback (most recent call last):
File "/home/ubuntu/ann-benchmarks/run.py", line 7, in
main()
File "/home/ubuntu/ann-benchmarks/ann_benchmarks/main.py", line 341, in main
raise Exception("Nothing to run")
Exception: Nothing to run

Expected Behavior

Run without error and show results

Steps To Reproduce

sudo python3 run.py --dataset sift-128-euclidean --algorithm milvus

Milvus Log

No response

Anything else?

No response

@pauldintel pauldintel added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 27, 2023
@yanliang567
Copy link
Contributor

it seems that not only milvus but also the other engines are not working. I think there are a few issues in the ann benchmark.
@wangting0128 could you please help to take a look?

/assign @wangting0128
/unassign

@yanliang567 yanliang567 added the help wanted Extra attention is needed label Sep 28, 2023
@yanliang567 yanliang567 removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 7, 2023
@wangting0128
Copy link
Contributor

Please try executing the following command to see if it works:
sudo python3 run.py --dataset glove-25-angular --algorithm 'Milvus(Knowhere)'

@yanliang567
Copy link
Contributor

/assign @pauldintel

@pauldintel
Copy link
Author

pauldintel commented Oct 7, 2023

thanks @wangting0128 . this works but how do I change connection to remote node ?
I tried below modification at module.py
import milvus
self._client = milvus.Milvus(host='IPaddress', port='19530', try_connect=True, pre_ping=False)
but it doesn't work.

@wangting0128
Copy link
Contributor

thanks @wangting0128 . this works but how do I change connection to remote node ? I tried below modification at module.py import milvus self._client = milvus.Milvus(host='IPaddress', port='19530', try_connect=True, pre_ping=False) but it doesn't work.

You need to rewrite the entire module.py file using the pymilvus package to support the function of connecting to remote milvus

@yanliang567
Copy link
Contributor

@pauldintel I'd suggest you use https://github.com/zilliztech/VectorDBBench if you are interested in Milvus service performance instead the Ann search engine.

@yanliang567
Copy link
Contributor

@pauldintel I'd suggest you use https://github.com/zilliztech/VectorDBBench if you are interested in Milvus service performance instead of in Ann search engine.

@pauldintel
Copy link
Author

sure @yanliang567 - I will git it a shot to try Milvus from there .. any chande @wangting0128 to update the code from knowwhere to pymilvus ? looks like the Dockerfile using 7 months old Milvus package that is no more as standard .

@yanliang567
Copy link
Contributor

sure @yanliang567 - I will git it a shot to try Milvus from there .. any chande @wangting0128 to update the code from knowwhere to pymilvus ? looks like the Dockerfile using 7 months old Milvus package that is no more as standard .

No, pymilvus is working only for milvus.

@pauldintel
Copy link
Author

sure @yanliang567 - I will git it a shot to try Milvus from there .. any chande @wangting0128 to update the code from knowwhere to pymilvus ? looks like the Dockerfile using 7 months old Milvus package that is no more as standard .

No, pymilvus is working only for milvus.

Okay thanks ... so how accurate will be knowhere benchmarking ? does it close to Milvus project or different ? @yanliang567 and if the remote connect option is not available through knowhere then only option to run benchmark on standalone machine correct ?

@yanliang567
Copy link
Contributor

knowhere is the engine in Milvus, you can run it as a lib, and milvus is a vector db system. thats the difference. If you want to knowhere the system performance, you may run https://github.com/zilliztech/VectorDBBench

@pauldintel
Copy link
Author

sorry @yanliang567 . My plan is to benchmark Milvus as vector DB so eventually this will benchmark knowhere as engine too correct ? I am stuck with VectorDBBench for different issue on library ...

@yanliang567
Copy link
Contributor

correct. please free to open an issue in the VectorDBBench repo if you any issue. I'd close this one if you agree

Copy link

stale bot commented Nov 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Nov 11, 2023
@stale stale bot closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/bug Issues or changes related a bug stale indicates no udpates for 30 days
Projects
None yet
Development

No branches or pull requests

3 participants