Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HNSW's param check #27412

Closed
wants to merge 1 commit into from
Closed

Conversation

liliu-z
Copy link
Member

@liliu-z liliu-z commented Sep 27, 2023

Align Milvus' parameter check with Knowhere

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Sep 27, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liliu-z
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Sep 27, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@liliu-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@liliu-z
Copy link
Member Author

liliu-z commented Oct 7, 2023

/run-cpu-e2e

@liliu-z
Copy link
Member Author

liliu-z commented Oct 7, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@liliu-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #27412 (0d5ccaf) into master (b80a3e1) will increase coverage by 0.00%.
Report is 23 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #27412   +/-   ##
=======================================
  Coverage   81.43%   81.44%           
=======================================
  Files         794      803    +9     
  Lines      114494   114586   +92     
=======================================
+ Hits        93239    93322   +83     
- Misses      18071    18081   +10     
+ Partials     3184     3183    -1     

see 176 files with indirect coverage changes

@liliu-z
Copy link
Member Author

liliu-z commented Oct 7, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2023

@liliu-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

stale bot commented Nov 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Nov 6, 2023
@stale stale bot closed this Nov 13, 2023
@liliu-z liliu-z deleted the update_param_check branch October 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. stale indicates no udpates for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants