New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if insert data matches schema #27401

Merged

sre-ci-robot merged 1 commit into milvus-io:master from xiaocai2333:check_array_data

Sep 28, 2023

Contributor

xiaocai2333 commented Sep 27, 2023

issue: #27333


          Check if insert data matches schema

653b25d

Signed-off-by: Cai Zhang <[email protected]>

sre-ci-robot added the size/L label

sre-ci-robot requested review from czs007 and godchen0212

September 27, 2023 06:52

mergify bot added the dco-passed label

xiaocai2333 mentioned this pull request

[Bug]: Milvus 2.3.2, always get [{}] for array type query response #27333

Closed

1 task

codecov bot commented Sep 27, 2023 •

edited

Loading

Codecov Report

Merging #27401 (653b25d) into master (b80a3e1) will increase coverage by 0.00%.
Report is 13 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master   #27401    +/-   ##
========================================
  Coverage   81.43%   81.44%            
========================================
  Files         794      803     +9     
  Lines      114494   114624   +130     
========================================
+ Hits        93239    93352   +113     
- Misses      18071    18088    +17     
  Partials     3184     3184

Files	Coverage Δ
internal/proxy/validate_util.go	`90.50% <100.00%> (+1.57%)`	⬆️

... and 163 files with indirect coverage changes

Collaborator

czs007 commented Sep 27, 2023

/approve
/lgtm

sre-ci-robot assigned czs007

sre-ci-robot added the lgtm label

Contributor

sre-ci-robot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~internal/proxy/OWNERS~~ [czs007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot added the approved label

Contributor

mergify bot commented Sep 27, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor Author

xiaocai2333 commented Sep 27, 2023

/run-cpu-e2e

Contributor

mergify bot commented Sep 27, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor Author

xiaocai2333 commented Sep 28, 2023

/run-cpu-e2e

Contributor

mergify bot commented Sep 28, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor Author

xiaocai2333 commented Sep 28, 2023

/run-cpu-e2e

Contributor

mergify bot commented Sep 28, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor Author

xiaocai2333 commented Sep 28, 2023

/run-cpu-e2e

1 similar comment

Contributor Author

xiaocai2333 commented Sep 28, 2023

/run-cpu-e2e

Contributor

mergify bot commented Sep 28, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor Author

xiaocai2333 commented Sep 28, 2023

/run-cpu-e2e

mergify bot added the ci-passed label

sre-ci-robot merged commit 2b64cfc into milvus-io:master

12 checks passed

xiaocai2333 deleted the check_array_data branch

November 1, 2023 12:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed lgtm size/L