Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine errors for import #27379

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Refine errors for import #27379

merged 1 commit into from
Sep 30, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Sep 26, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/L Denotes a PR that changes 100-499 lines. labels Sep 26, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #27379 (1561e1e) into master (dbdb9e1) will decrease coverage by 0.01%.
The diff coverage is 85.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27379      +/-   ##
==========================================
- Coverage   81.44%   81.43%   -0.01%     
==========================================
  Files         804      803       -1     
  Lines      114698   114625      -73     
==========================================
- Hits        93415    93350      -65     
+ Misses      18093    18089       -4     
+ Partials     3190     3186       -4
Files Coverage Δ
internal/distributed/datanode/service.go 81.94% <100.00%> (-0.25%) ⬇️
internal/proxy/util.go 89.65% <100.00%> (+0.77%) ⬆️
internal/querycoordv2/services.go 84.83% <100.00%> (-0.02%) ⬇️
internal/rootcoord/root_coord.go 90.15% <100.00%> (-0.02%) ⬇️
pkg/util/merr/errors.go 93.75% <ø> (ø)
pkg/util/merr/utils.go 92.67% <ø> (-0.07%) ⬇️
internal/proxy/impl.go 83.97% <94.44%> (+0.11%) ⬆️
internal/distributed/proxy/service.go 79.49% <50.00%> (+0.49%) ⬆️
internal/rootcoord/import_manager.go 75.70% <85.71%> (-0.46%) ⬇️
internal/indexnode/indexnode_service.go 88.54% <61.11%> (-3.48%) ⬇️

... and 18 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

1 similar comment
@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 27, 2023

/run-cpu-e2e

@mergify mergify bot removed the ci-passed label Sep 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

jiaoew1991
jiaoew1991 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@jiaoew1991 jiaoew1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot removed the lgtm label Sep 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 28, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 28, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01 yah01 force-pushed the remove-err branch 2 times, most recently from 3ab2b84 to 1561e1e Compare September 29, 2023 08:06
@mergify mergify bot added the ci-passed label Sep 29, 2023
congqixia
congqixia approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 63ac43a into milvus-io:master Sep 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@jiaoew1991 jiaoew1991 jiaoew1991 approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@jiaoew1991 jiaoew1991

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yah01 @sre-ci-robot @jiaoew1991 @congqixia