Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return element type for describing collection #27363

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Return element type for describing collection #27363

merged 1 commit into from
Sep 28, 2023

Conversation

xiaocai2333
Copy link
Contributor

issue: #27322

@xiaocai2333
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Sep 26, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 26, 2023
@xiaocai2333 xiaocai2333 added this to the 2.3.2 milestone Sep 26, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@xiaocai2333 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #27363 (67073ab) into master (fd979a7) will increase coverage by 0.00%.
Report is 13 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #27363   +/-   ##
=======================================
  Coverage   81.50%   81.51%           
=======================================
  Files         801      801           
  Lines      114371   114372    +1     
=======================================
+ Hits        93220    93229    +9     
+ Misses      17968    17961    -7     
+ Partials     3183     3182    -1
Files Coverage Δ
internal/proxy/task.go 85.32% <100.00%> (+0.01%) ⬆️

... and 18 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Sep 27, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 28, 2023
@sre-ci-robot sre-ci-robot merged commit 91244f0 into milvus-io:master Sep 28, 2023
12 checks passed
@xiaocai2333 xiaocai2333 deleted the return_element_type branch November 1, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot