Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make madvice of ChunkCache configurable #27291

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Make madvice of ChunkCache configurable #27291

merged 1 commit into from
Sep 28, 2023

Conversation

bigsheeper
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/M Denotes a PR that changes 30-99 lines. labels Sep 21, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2023

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #27291 (e52dff3) into master (8c59dba) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 81.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27291      +/-   ##
==========================================
+ Coverage   81.44%   81.46%   +0.01%     
==========================================
  Files         803      794       -9     
  Lines      114591   114531      -60     
==========================================
- Hits        93330    93298      -32     
+ Misses      18077    18050      -27     
+ Partials     3184     3183       -1
Files Coverage Δ
internal/core/src/storage/ChunkCache.cpp 95.23% <ø> (-0.22%) ⬇️
internal/core/src/storage/ChunkCache.h 100.00% <100.00%> (ø)
internal/core/src/storage/Util.cpp 81.02% <ø> (-0.64%) ⬇️
internal/querynodev2/server.go 64.92% <100.00%> (+0.10%) ⬆️
internal/util/initcore/init_core.go 84.81% <100.00%> (+0.39%) ⬆️
pkg/util/paramtable/component_param.go 98.08% <100.00%> (+<0.01%) ⬆️
internal/core/src/storage/storage_c.cpp 0.00% <0.00%> (ø)
internal/core/src/storage/ChunkCacheSingleton.h 50.00% <0.00%> (ø)

... and 158 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 22, 2023

/approve

yah01
yah01 reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also apply this to column type in Column.h

@mergify mergify bot added the ci-passed label Sep 25, 2023
yah01
yah01 reviewed Sep 26, 2023
View reviewed changes
configs/milvus.yaml Outdated Show resolved Hide resolved
internal/core/src/storage/ChunkCache.cpp Outdated Show resolved Hide resolved
internal/core/src/storage/ChunkCache.h Outdated Show resolved Hide resolved
yah01
yah01 reviewed Sep 26, 2023
View reviewed changes
internal/core/src/storage/ChunkCache.h Outdated Show resolved Hide resolved
internal/core/src/storage/ChunkCacheSingleton.h Outdated Show resolved Hide resolved
@mergify mergify bot removed the ci-passed label Sep 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 28, 2023
@czs007
Copy link
Collaborator

czs007 commented Sep 28, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 106c17f into milvus-io:master Sep 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yah01 yah01 yah01 left review comments

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bigsheeper @czs007 @sre-ci-robot @yah01