Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize rocksmq performance #26497

Closed
wants to merge 1 commit into from
Closed

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Aug 21, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 21, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 21, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

@sunby sunby force-pushed the improve_rmq_master branch from e8f5e69 to 629dbfd Compare August 21, 2023 08:17
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby sunby force-pushed the improve_rmq_master branch from 629dbfd to 2929ccb Compare August 21, 2023 08:38
@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Aug 22, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

@sunby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot removed the dco-passed DCO check passed. label Aug 22, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

@sunby, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Aug 22, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

@sunby sunby force-pushed the improve_rmq_master branch from 981bcf6 to 75e5e98 Compare August 22, 2023 07:43
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. needs-rebase labels Aug 22, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby sunby force-pushed the improve_rmq_master branch 2 times, most recently from 0c9827a to aacdab0 Compare August 23, 2023 07:06
@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Aug 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

@sunby Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

@sunby, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Aug 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby sunby force-pushed the improve_rmq_master branch from aacdab0 to 44f911f Compare August 23, 2023 08:03
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. needs-rebase labels Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #26497 (44f911f) into master (09218bf) will decrease coverage by 2.48%.
Report is 7 commits behind head on master.
The diff coverage is 88.28%.

❗ Current head 44f911f differs from pull request most recent head d71d976. Consider uploading reports for the commit d71d976 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26497      +/-   ##
==========================================
- Coverage   82.31%   79.83%   -2.48%     
==========================================
  Files         796      821      +25     
  Lines      111183   112726    +1543     
==========================================
- Hits        91516    89994    -1522     
- Misses      16540    19512    +2972     
- Partials     3127     3220      +93     
Files Changed Coverage Δ
pkg/mq/msgstream/mq_msgstream.go 74.21% <62.50%> (-4.74%) ⬇️
internal/mq/mqimpl/rocksmq/server/rocksmq_impl.go 84.93% <88.36%> (+2.13%) ⬆️
...rnal/mq/mqimpl/rocksmq/server/rocksmq_retention.go 78.03% <100.00%> (+1.30%) ⬆️
pkg/util/paramtable/service_param.go 95.07% <100.00%> (-3.52%) ⬇️

... and 195 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 23, 2023
@sunby sunby force-pushed the improve_rmq_master branch from 44f911f to 03492f6 Compare August 29, 2023 04:40
@mergify mergify bot removed the ci-passed label Aug 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby sunby force-pushed the improve_rmq_master branch 2 times, most recently from 8f13d87 to 82dc33b Compare September 1, 2023 03:13
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby sunby force-pushed the improve_rmq_master branch from 82dc33b to d71d976 Compare September 1, 2023 07:46
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@stale
Copy link

stale bot commented Oct 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Oct 1, 2023
@stale stale bot closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor size/XL Denotes a PR that changes 500-999 lines. stale indicates no udpates for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants