diff --git a/internal/core/CMakeLists.txt b/internal/core/CMakeLists.txt index 268b4293c80a2..3914db12fe3ca 100644 --- a/internal/core/CMakeLists.txt +++ b/internal/core/CMakeLists.txt @@ -153,7 +153,6 @@ if ( APPLE ) "-Wno-gnu-zero-variadic-macro-arguments" "-Wno-variadic-macros" "-Wno-reorder-ctor" - "-Wno-google-readability" "-DBOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED=1" ) endif () diff --git a/internal/core/src/mmap/ChunkedColumn.h b/internal/core/src/mmap/ChunkedColumn.h index 0fd7a8684c904..a75f648460923 100644 --- a/internal/core/src/mmap/ChunkedColumn.h +++ b/internal/core/src/mmap/ChunkedColumn.h @@ -60,7 +60,6 @@ class ChunkedColumnBase : public ColumnBase { } virtual ~ChunkedColumnBase() = default; - ; void AppendBatch(const FieldDataPtr data) override { diff --git a/internal/core/unittest/test_chunk_cache.cpp b/internal/core/unittest/test_chunk_cache.cpp index 9888097e59ac8..aedd4926513b8 100644 --- a/internal/core/unittest/test_chunk_cache.cpp +++ b/internal/core/unittest/test_chunk_cache.cpp @@ -150,7 +150,7 @@ TEST_P(ChunkCacheTest, Read) { dense_file_name, descriptor, dense_field_meta, mmap_enabled); Assert(dense_column->DataByteSize() == dim * N * 4); } - auto actual_dense = (const float*)(dense_column->Data()); + auto actual_dense = (const float*)(dense_column->Data(0)); for (auto i = 0; i < N * dim; i++) { AssertInfo(dense_data[i] == actual_dense[i], fmt::format( @@ -168,7 +168,7 @@ TEST_P(ChunkCacheTest, Read) { } auto expected_sparse_size = 0; auto actual_sparse = - (const knowhere::sparse::SparseRow*)(sparse_column->Data()); + (const knowhere::sparse::SparseRow*)(sparse_column->Data(0)); for (auto i = 0; i < N; i++) { const auto& actual_sparse_row = actual_sparse[i]; const auto& expect_sparse_row = sparse_data[i]; @@ -215,7 +215,7 @@ TEST_P(ChunkCacheTest, TestMultithreads) { Assert(dense_column->DataByteSize() == dim * N * 4); } - auto actual_dense = (const float*)dense_column->Data(); + auto actual_dense = (const float*)dense_column->Data(0); for (auto i = 0; i < N * dim; i++) { AssertInfo( dense_data[i] == actual_dense[i], @@ -232,7 +232,7 @@ TEST_P(ChunkCacheTest, TestMultithreads) { sparse_file_name, descriptor, sparse_field_meta, mmap_enabled); } auto actual_sparse = - (const knowhere::sparse::SparseRow*)sparse_column->Data(); + (const knowhere::sparse::SparseRow*)sparse_column->Data(0); for (auto i = 0; i < N; i++) { const auto& actual_sparse_row = actual_sparse[i]; const auto& expect_sparse_row = sparse_data[i];