Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GetVersion #233

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Support GetVersion #233

merged 1 commit into from
Mar 23, 2023

Conversation

matrixji
Copy link
Collaborator

Fixes: #220

Signed-off-by: Ji Bin [email protected]

Fixes: milvus-io#220

Signed-off-by: Ji Bin <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matrixji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #233 (c65a769) into master (6c6f87c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   97.39%   97.40%           
=======================================
  Files          34       34           
  Lines        2572     2581    +9     
=======================================
+ Hits         2505     2514    +9     
  Misses         67       67           
Impacted Files Coverage Δ
src/impl/MilvusClientImpl.h 100.00% <ø> (ø)
src/impl/MilvusConnection.h 100.00% <ø> (ø)
src/impl/MilvusClientImpl.cpp 94.77% <100.00%> (+0.04%) ⬆️
src/impl/MilvusConnection.cpp 99.23% <100.00%> (+0.01%) ⬆️

@matrixji matrixji added the lgtm label Mar 23, 2023
@sre-ci-robot sre-ci-robot merged commit 6723456 into milvus-io:master Mar 23, 2023
@matrixji matrixji mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AlterCollection
2 participants