We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello,
I was testing the emoji regex and noticed that it doesn't match thumbs up emoji if it doesn't have skin color
const EMOJI_REGEX = require('emojibase-regex/emoji'); console.log('Match for 👍🏻 :', '👍🏻'.match(EMOJI_REGEX)) // -> Match for 👍🏻 : [ '👍🏻', index: 0, input: '👍🏻', groups: undefined ] console.log('Match for 👍 :','👍'.match(EMOJI_REGEX)) // -> Match for 👍 : null
Here is a link to REPL https://replit.com/@MikeYermolayev/emojibase-regex-repro
Thank you
The text was updated successfully, but these errors were encountered:
The issue in other words: #174
Sorry, something went wrong.
This is a bit weird since we have tests that check all emojis: https://github.com/milesj/emojibase/blob/master/packages/regex/tests/regex.test.ts#L67
Ok yeah, I misread the post. Yeah emoji regex requires a variant modifier, which 👍 does not have. So you want emoji-loose.
emoji
emoji-loose
This is "working as intended" right now, but I think in the next version I'm going to remove the loose regex as it causes confusion.
No branches or pull requests
Hello,
I was testing the emoji regex and noticed that it doesn't match thumbs up emoji if it doesn't have skin color
Here is a link to REPL https://replit.com/@MikeYermolayev/emojibase-regex-repro
Thank you
The text was updated successfully, but these errors were encountered: