Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant functions, fixed .gitignore #172

Merged

Conversation

swilliamson7
Copy link
Collaborator

Moved the checkpointed time integration function to its own script, I can't really think of a better way without adding using Checkpointing to the main ShallowWaters.jl file

@swilliamson7
Copy link
Collaborator Author

The diffs on time_integration.jl look weird to me, but they're correct on my computer so who knows

@swilliamson7 swilliamson7 merged commit 7ea6507 into milankl:sw/single-struct Apr 11, 2024
1 check passed
@milankl
Copy link
Owner

milankl commented Apr 11, 2024

Moved the checkpointed time integration function to its own script, I can't really think of a better way without adding using Checkpointing to the main ShallowWaters.jl file

We could make Checkpointing an extensions, see https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)

Then some code is only loaded when the user says using Checkpointing, how does that sound?

@swilliamson7
Copy link
Collaborator Author

Sure! That should work. I can make that into a separate pull request, for now I just haven't included the checkpointed time integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants