Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add different min / max values for Path spacing depending on Mammotion model #125

Open
Tra1n84 opened this issue Sep 13, 2024 · 1 comment
Open

Add different min / max values for Path spacing depending on Mammotion model #125

Tra1n84 opened this issue Sep 13, 2024 · 1 comment

Comments

@Tra1n84
Copy link
Contributor

Tra1n84 commented Sep 13, 2024

The problem

Hello,

as already discussed via Discord I noticed that the lowest value which can be set for a Yuka mower at Path spacing is 20cm even if the Yuka can go down to 15cm. The maximum you can choose with the Yuka is 30cm, but with the Luba you have 35cm..

So there are some differences between all models. I can see that the Min / Max Values of Path spacing (in number.py) are currently filled with constants.

I know from dicsussion in Discord that Michael (@mikey0000) wants to pull the values differently per each model and that he is already thinking and/or working on that topic. This issue is intended to ensure that the different values per model will also taken into account for the Path spacing.

Best regards
Thomas

What Mammotion mower are you using?

Yuka

What version of the Mammotion intergration are you using?

0.1.31

What version of Home Assistant Core are you running?

core-2024.9.1
hurtigit added a commit to hurtigit/Mammotion-HA that referenced this issue Sep 19, 2024
@hurtigit
Fix path spacing for different Mammotion models
77f915d 
Fixes mikey0000#125

Update `path_spacing` entity to dynamically set min and max values based on Mammotion model.

* Set `min_value` to 15 and `max_value` to 30 for Yuka model.
* Set `min_value` to 20 and `max_value` to 35 for Luba model.
* Use `DeviceType` utility to determine the model type.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/mikey0000/Mammotion-HA/issues/125?shareId=XXXX-XXXX-XXXX-XXXX).
@hurtigit hurtigit mentioned this issue Sep 19, 2024
Closed
@mikey0000
Copy link
Owner

Path spacing and so on have been adjusted, model specific settings are coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dynamic path spacing adjustment for Mammotion models hurtigit/Mammotion-HA
2 participants
@mikey0000 @Tra1n84