Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide labels when a cycle is detected #12

Open
milesj opened this issue Dec 22, 2021 · 3 comments
Open

Provide labels when a cycle is detected #12

milesj opened this issue Dec 22, 2021 · 3 comments

Comments

@milesj
Copy link

milesj commented Dec 22, 2021

Right now the cycle detection isn't very helpful since it doesn't tell you where the actual problem is.

It would be nice if it included a vector of the cycle path that triggered it, for example: SolventError::CycleDetected(vec!["foo", "bar", "baz", "foo"]).

@mikedilger
Copy link
Owner

I just pushed a commit that should do what you want. It passes internal tests, but I haven't used it myself (I haven't used solvent in years). Let me know if it works for you.

@milesj
Copy link
Author

milesj commented Dec 22, 2021

@mikedilger Not seeing any commit :P

@mikedilger
Copy link
Owner

Oops I pushed it to my private repo server. Check now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants