Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preinstall neovim dependencies before integration-tests #592

Merged
merged 4 commits into from
Nov 30, 2024
Merged

Conversation

mikavilpas
Copy link
Owner

ci: preinstall neovim plugins before integration-tests

Previously this caused the first 1-2 tests to fail, although this was always caught by retries. It's not very clean to have these failures, so let's be clear and install all neovim plugins beforehand.

ci: update the nightly version of yazi to the latest nightly

refactor(tests): reduce fake type errors in tests

I recently added the types of luassert to my neovim config. It looks
like they disallow many values that actually exist at runtime, so they
are not very good. I will remove them for now anyway, since it's easy.

https://github.com/mikavilpas/dotfiles/blob/b9f67f74ff4075d78fada7ec064e6234a02a2b71/.config/nvim/lua/plugins/luadev.lua?plain=1#L4-L5

dependabot bot and others added 3 commits November 29, 2024 22:38
… with 8 updates

Bumps the npm-dependencies group with 8 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [prettier](https://github.com/prettier/prettier) | `3.3.3` | `3.4.1` |
| [prettier-plugin-packagejson](https://github.com/matzkoh/prettier-plugin-packagejson) | `2.5.5` | `2.5.6` |
| @tui-sandbox/library | `7.2.0` | `7.2.1` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.9.1` | `22.10.1` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `8.15.0` | `8.16.0` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `8.15.0` | `8.16.0` |
| [eslint](https://github.com/eslint/eslint) | `9.15.0` | `9.16.0` |
| [type-fest](https://github.com/sindresorhus/type-fest) | `4.27.0` | `4.29.0` |

Bumps the npm-dependencies group with 6 updates in the /integration-tests directory:

| Package | From | To |
| --- | --- | --- |
| @tui-sandbox/library | `7.2.0` | `7.2.1` |
| [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.9.1` | `22.10.1` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `8.15.0` | `8.16.0` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `8.15.0` | `8.16.0` |
| [eslint](https://github.com/eslint/eslint) | `9.15.0` | `9.16.0` |
| [type-fest](https://github.com/sindresorhus/type-fest) | `4.27.0` | `4.29.0` |



Updates `prettier` from 3.3.3 to 3.4.1
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.3.3...3.4.1)

Updates `prettier-plugin-packagejson` from 2.5.5 to 2.5.6
- [Release notes](https://github.com/matzkoh/prettier-plugin-packagejson/releases)
- [Commits](matzkoh/prettier-plugin-packagejson@v2.5.5...v2.5.6)

Updates `@tui-sandbox/library` from 7.2.0 to 7.2.1

Updates `@types/node` from 22.9.1 to 22.10.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `@typescript-eslint/eslint-plugin` from 8.15.0 to 8.16.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.16.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.15.0 to 8.16.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.16.0/packages/parser)

Updates `eslint` from 9.15.0 to 9.16.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.15.0...v9.16.0)

Updates `type-fest` from 4.27.0 to 4.29.0
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.27.0...v4.29.0)

Updates `@tui-sandbox/library` from 7.2.0 to 7.2.1

Updates `@types/node` from 22.9.1 to 22.10.1
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `@typescript-eslint/eslint-plugin` from 8.15.0 to 8.16.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.16.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.15.0 to 8.16.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.16.0/packages/parser)

Updates `eslint` from 9.15.0 to 9.16.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.15.0...v9.16.0)

Updates `type-fest` from 4.27.0 to 4.29.0
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.27.0...v4.29.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: prettier-plugin-packagejson
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-dependencies
- dependency-name: "@tui-sandbox/library"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-dependencies
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: type-fest
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: "@tui-sandbox/library"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-dependencies
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
- dependency-name: type-fest
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
I recently added the types of luassert to my neovim config. It looks
like they disallow many values that actually exist at runtime, so they
are not very good. I will remove them for now anyway, since it's easy.

https://github.com/mikavilpas/dotfiles/blob/b9f67f74ff4075d78fada7ec064e6234a02a2b71/.config/nvim/lua/plugins/luadev.lua?plain=1#L4-L5
Previously this caused the first 1-2 tests to fail, although this was
always caught by retries. It's not very clean to have these failures, so
let's be clear and install all neovim plugins beforehand.
@mikavilpas mikavilpas merged commit a54ec05 into main Nov 30, 2024
16 checks passed
@mikavilpas mikavilpas deleted the preinstall branch November 30, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant