Performance improvements for the integration tests #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with 3 updates Bumps the npm-dependencies group with 3 updates in the / directory: [prettier-plugin-packagejson](https://github.com/matzkoh/prettier-plugin-packagejson), @tui-sandbox/library and [typescript](https://github.com/microsoft/TypeScript). Bumps the npm-dependencies group with 2 updates in the /integration-tests directory: @tui-sandbox/library and [typescript](https://github.com/microsoft/TypeScript). Updates `prettier-plugin-packagejson` from 2.5.3 to 2.5.5 - [Release notes](https://github.com/matzkoh/prettier-plugin-packagejson/releases) - [Commits](matzkoh/prettier-plugin-packagejson@v2.5.3...v2.5.5) Updates `@tui-sandbox/library` from 6.1.0 to 7.0.1 Updates `typescript` from 5.6.3 to 5.7.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.6.3...v5.7.2) Updates `@tui-sandbox/library` from 6.1.0 to 7.0.1 Updates `typescript` from 5.6.3 to 5.7.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.6.3...v5.7.2) --- updated-dependencies: - dependency-name: prettier-plugin-packagejson dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-dependencies - dependency-name: "@tui-sandbox/library" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-dependencies - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-dependencies - dependency-name: "@tui-sandbox/library" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-dependencies - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
Instead of typing into the terminal to run ex commands, use the `cy.runExCommand` command. I added it to tui-sandbox today, and it uses the neovim node api via a socket connection. This seems to speed up the entire integration test suite by about 3-7 seconds (~47 s now on my machine). The speedup comes from the fact that we don't have to wait for the characters to be typed into the terminal, and we don't have to wait for the output to appear on the screen in order to assert on it. It also makes the tests more reliable, as in some cases `cy.typeIntoTerminal` cannot be used to assert that something does not exist in the output (since we don't know when the output is done).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf(tests): use
cy.runExCommandin all testsInstead of typing into the terminal to run ex commands, use the
cy.runExCommandcommand. I added it to tui-sandbox today, and it usesthe neovim node api via a socket connection. This seems to speed up the
entire integration test suite by about 3-7 seconds (~47 s now on my
machine).
The speedup comes from the fact that we don't have to wait for the
characters to be typed into the terminal, and we don't have to wait for
the output to appear on the screen in order to assert on it.
It also makes the tests more reliable, as in some cases
cy.typeIntoTerminalcannot be used to assert that something does notexist in the output (since we don't know when the output is done).