LSP renaming support is unreliable #80
Comments
|
Great idea, thank you! I will try that out later. |
|
This issue is stale because it has been open for 30 days with no activity. |
|
With the recent changes in lazy.nvim, it would be easy to add a new dependency #144 I don't necessarily want to maintain the feature myself so https://github.com/antosha417/nvim-lsp-file-operations would be a good option. Will have to see it it's available for rocks.nvim users. |
mikavilpas
added
bug
mikavilpas
added a commit
that referenced
this issue
Jul 13, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80>
mikavilpas
added a commit
that referenced
this issue
Jul 13, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80>
This was referenced Jul 13, 2024
mikavilpas
added a commit
that referenced
this issue
Jul 15, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80>
mikavilpas
added a commit
that referenced
this issue
Jul 16, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80>
mikavilpas
added a commit
that referenced
this issue
Jul 21, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80>
mikavilpas
added a commit
that referenced
this issue
Jul 25, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80>
mikavilpas
added a commit
that referenced
this issue
Jul 25, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80> This work was started in #190 where the idea is to add a dependency on nvim-lsp-file-operations, but that PR has become slightly stalled for now. This PR is a temporary fix to this stalling by simply embedding the new package inside yazi.nvim for now. When the issues in the PR have been resolved, the embedding can be removed.
mikavilpas
added a commit
that referenced
this issue
Jul 25, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80> This work was started in #190 where the idea is to add a dependency on nvim-lsp-file-operations, but that PR has become slightly stalled for now. This PR is a temporary fix to this stalling by simply embedding the new package inside yazi.nvim for now. When the issues in the PR have been resolved, the embedding can be removed.
mikavilpas
added a commit
that referenced
this issue
Jul 25, 2024
There were some edge cases that caused issues when renaming files with LSP servers. Hopefully fix all of them by using the implementation that's also shared by neotree and nvim-tree: https://github.com/antosha417/nvim-lsp-file-operations Thanks @chaozwn for suggesting the fix! Closes <#80> This work was started in #190 where the idea is to add a dependency on nvim-lsp-file-operations, but that PR has become slightly stalled for now. This PR is a temporary fix to this stalling by simply embedding the new package inside yazi.nvim for now. When the issues in the PR have been resolved, the embedding can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Typescript's LSP (tsserver) seems to handle renames quite well.
Rust-analyzer seems to be capable of handling renames for the current file well, but not at all for other files besides the current file.
In my testing, neo-tree was able to handle renames quite reliably for all cases.
This might be caused by the fact that yazi renames the files before yazi.nvim can notify the LSP that it
willRenameFiles. This might require deeper integration to be implemented in yazi.A discussion for deeper integration has been started here sxyazi/yazi#989 and can be tracked there
The text was updated successfully, but these errors were encountered: