Skip to content

Commit

Permalink
ci: don't run lint and style checks on push events (#510)
Browse files Browse the repository at this point in the history
Issue
=====

Currently these jobs run when a pull_request is created or updated:

```text
Linkspector / runner / linkspector (pull_request) Successful in 2m
Linting / markdownlint (pull_request) Successful in 4s
Linting / markdownlint (push) Successful in 3s
Linting / selene (pull_request) Successful in 4s
Linting / selene (push) Successful in 3s
LuaRocks release / LuaRocks upload (pull_request) Successful in 28s
Run tests / Run tests (nightly) (pull_request) Successful in 2m
Run tests / Run tests (stable) (pull_request) Successful in 2m
Style checking / prettier (pull_request) Successful in 32s
Style checking / prettier (push) Successful in 29s
Style checking / stylua (pull_request) Successful in 3s
Style checking / stylua (push) Successful in 3s
Type check / Type check (pull_request) Successful in 14s
reviewdog eslint / runner / eslint (pull_request) Successful in 43s
```

#508

There are duplicate jobs for push and pull_request events. This is
unnecessary and can be removed.

Solution
========

Remove the push event from the lint and style workflows.
  • Loading branch information
mikavilpas authored Oct 9, 2024
1 parent 55e6673 commit a4e9d2c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Linting

on: [push, pull_request]
on: [pull_request]

jobs:
selene:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/style.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@

name: Style checking

on: [push, pull_request]
on:
pull_request: ~
push:
branches:
- main

jobs:
prettier:
Expand Down

0 comments on commit a4e9d2c

Please sign in to comment.