Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Sleep pin causes Ring pin to not work correctly. #41

Open
iliabaranov opened this issue Aug 29, 2022 · 5 comments
Open

Use of Sleep pin causes Ring pin to not work correctly. #41

iliabaranov opened this issue Aug 29, 2022 · 5 comments

Comments

@iliabaranov
Copy link

iliabaranov commented Aug 29, 2022

Hello,

Taking a look at the Ring example, simply adding in SLEEP_PIN causes the RING_PIN to falsely detect a Ring even when none is occurring. Not sure why...

On that note, I suggest using Pullup declaration in line 100 in IridiumSBD.h, to ensure Ring does fire properly, as this is an active low signal.

     pinMode(ringPin, INPUT_PULLUP);

I checked, and removing this change of mine does not cause the issue above to disappear.

@iliabaranov
Copy link
Author

Seem to be able to correct this by adding this to the end of the setup section:
modem.hasRingAsserted();

It seems that using both sleep and ring causes ring to falsely go low during setup, reading it back has the effect of clearing this out

@adamgarbo
Copy link

I don't believe this library is maintained any longer.

I would recommend using the SparkFun fork maintained and enhanced by Paul Clark: https://github.com/sparkfun/SparkFun_IridiumSBD_I2C_Arduino_Library

@PaulZC
Copy link

PaulZC commented Aug 29, 2022

Hi Ilia (@iliabaranov ),

I ran into a similar ring pin issue a few years ago - possibly the same one. My fix - at the time - was the following:

"Included a fix to let the serial Ring example work properly (hasRingAsserted now checks the ringPin itself instead of assuming cancelled will be able to do it)."

See the changes to IridiumSBD.cpp in this commit:

PaulZC@7a49765

The changes were included when we created the SparkFun fork. The SparkFun fork isn't intended to gatecrash Mikal's library, we gratefully took what he'd written and then added on I2C support for the "Qwiic Iridium" product.

I hope this helps,
Paul

@adamgarbo
Copy link

Also to clarify, I only make the suggestion because I know there have been a number of issues that have been addressed in the SparkFun fork!

@mikalhart do you think it could be worth making a note on your repository stating the library's status (e.g., active, inactive, etc.)? This could help give new and existing users a heads up as to the likelihood of their issues being addressed.

Cheers,
Adam

@mikalhart
Copy link
Owner

Hi guys. @PaulZC... thrilled to see that Sparkfun is supporting this great technology. Yes indeed, I'm particularly glad that this issue with the apparent Ring/Sleep interdependence at least has a workaround. (I thought it was something peculiar with my own setup!)

@adamgarbo I may do exactly what you suggest. I'm traveling a lot these days and am not in a great position to do the testing necessary to support this work.

Thanks, all, for comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants