Terminal Rendering Defect

[ghost]

Hi,

I work on CodeEdit and there's a terminal rendering defect. We use SwiftTerm as the package for our terminal emulator

Click here to see the issue and please comment on it as soon as you can.

[austincondiff]

To provide some context:

• The bottom line seems to extend further than it should.
• Vertical alignment of characters is slightly off in comparison to Terminal.app
• Resizing the window causes artifacts

Expected behavior:

[migueldeicaza]

Hello,

The bottom of the screen issue has been fixed recently, this is a topic of debate between me anr Marcin, he likes one visual style, and I like the other. I might introduce a flag to control that, so we can both be happy,but for now, the code in the repository should match your expectation.

Can you provide a simple script that would render the unaligned text, so I can take a look?

[migueldeicaza]

OMG I did not know about CodeEdit - this is incredible! I love what I see!

[austincondiff]

Thank you! Spread the word, we have big plans for it. We always appreciate more contributors if you'd care to help out as this is a community led effort! 😉

[austincondiff]

By misaligned text I am referring to the following...

The triangles and half circles are not in alignment to characters with a background color in between.

Terminal.app is sightly out of alignment in the opposite direction.

[migueldeicaza]

Could you get the original poster to share the tool he uses to produce that prompt, so I can try to repro locally?

[austincondiff]

He was commenting on a lot of our issues for a few days, changed his username, and then a day later he just deleted his account (why you see ghost as the username).

I use powerlevel10k for zsh to get this prompt shown above.

[austincondiff]

Any progress on this issue? Have you been able to reproduce this?

[migueldeicaza]

I have not had a chance to look at it.

Generally, I think we have the right size for the rows, as computed by this:

But I suspect that I might be missing something, a similar challenge (for Chinese display) is that I do not call CTRunGetPositions, and that might be one of the missing parts of the puzzle, see this issue:

#227

(And somewhat related, CTRunGetAdvances)

[austincondiff]

@migueldeicaza I see, thanks for the insight!

cc/ @bombardier200

[krzyzanowskim]

this is a topic of debate between me anr Marcin

I still think you're wrong about it. It looks bad with configureNativeColors() with a white background behind it. I'm not sure why the last row (not full) has to be drawn like that. peace.