Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: 06-shopping-cart CSS #56

Open
salvaft opened this issue Feb 17, 2023 · 0 comments
Open

Discussion: 06-shopping-cart CSS #56

salvaft opened this issue Feb 17, 2023 · 0 comments

Comments

@salvaft
Copy link

salvaft commented Feb 17, 2023

Buenas,
Me permito abrir una issue para aclarar una duda en el CSS que no está muy clara. De hecho, se le ve dubitativo al propio Miguel durante el directo.
También me he permitido traladar el codigo a un sandbox por si alguien quiere probar rapidamente el cambio al activar y desactivar el flex container.

https://codesandbox.io/s/headless-paper-m7i8r4?file=/src/components/Products.css

Para enfatizar el efecto he aumentado el max-width del #root a 1200px

CODE:
Las líneas de código son las siguientes:

.products {
width: 100%;
display: flex;
justify-content: center;
align-items: center;
}

ISSUE:
Un contenedor flex envuelve a un grid

WHY IS AN ISSUE:
El flex container que envuelve al grid container hace que el grid se limite a dos columnas, y pase a 1 en pantallas pequeñas. Pero a mi parecer elimina el efecto repeat autofit min max del grid.

MEDIA
Flex container desactivado
Screencast from 17-02-2023 09:37:05.webm
Flex container activado
Screenshot from 2023-02-17 09-36-14

Gracias de antemano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant