-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Client Options #712
Comments
After taking a look at this, the only mandatory parameter for BaseGraphRequestAdapter is the authprovider similar to the Kiota abstractions HttpClientRequestAdapter. Currently, the initialization with core library is as below. var authProvider = new AzureIdentityAuthenticationProvider(interactiveBrowserCredential, scopes: scopes);
var graphClient = new ApiClient(new BaseGraphRequestAdapter(authProvider));// Create the API client
var messages = await graphClient.Me.Messages.GetAsync(); |
Adding more context. We should have a RequestAdapter factory on core that would provide something like this:
|
I used Kiota to generate a customized .NET client library targeting the Graph API and have added the Graph .NET core library to my project.
When creating a new BaseGraphRequestAdapter users can pass their own clientOptions what might be a strange scenario since the clientOption is used to inject telemetry data around SDK versioning.
We should have a default client option where in an absence of a user using service library version, we set up the core library values as default, so when creating a new adapter, the core version will be sent to out telemetry.
The text was updated successfully, but these errors were encountered: