Implementing Terminal: Run Recent Commad when there are no open terminal #234124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Tyriar
requested changes
Nov 22, 2024
There was a problem hiding this comment.
I don't think we should be doing anything outside of the command implementation. Everything you need to do should be able to be done there. You might need to change it to registerTerminalAction instead in order to get it to run when a terminal doesn't actually exist yet.
Comment on lines
252
to
263
| run: async (c, accessor, args) => { | ||
| let activeInstance = c.service.activeInstance; | ||
| const id = options.id; | ||
| if (activeInstance) { | ||
| return originalRun(activeInstance, c, accessor, args); | ||
| } | ||
| if (id !== 'workbench.action.terminal.runRecentCommand') { | ||
| return; | ||
| } | ||
| const commandService = accessor.get(ICommandService); | ||
| await commandService.executeCommand('workbench.action.terminal.new'); | ||
| activeInstance = c.service.activeInstance; |
There was a problem hiding this comment.
This is a generic function so you shouldn't be changing this, instead you should change the run callback passed in when it's called.
…d changing generic functions
|
@Tyriar I changed it in order to avoid changing the generic function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #233604
The command 'Terminal: Run Recent Command' will now create a new terminal if no terminals are currently open.
Simply creating a new terminal is not sufficient for the recent command window to display correctly.
When a new terminal is created, it looks like it takes some more time to fully update its related variables, so I inserted a loop of quick sleep functions (up to 5 seconds in total) while continuosly trying to display the recent command window.