Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: There should be an option to hide the menu bar. #945

Closed
be5invis opened this issue Dec 2, 2015 · 32 comments
Closed

Windows: There should be an option to hide the menu bar. #945

be5invis opened this issue Dec 2, 2015 · 32 comments
Assignees
Labels
feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@be5invis
Copy link
Contributor

be5invis commented Dec 2, 2015

No description provided.

@alexdima
Copy link
Member

alexdima commented Dec 3, 2015

Not sure if the fullscreen mode does this

@be5invis
Copy link
Contributor Author

be5invis commented Dec 3, 2015

@alexandrudima Full screen mode indeed hides menu bar, but providing an option for normal mode is better.

@bpasero bpasero added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality labels Dec 3, 2015
@bpasero bpasero removed their assignment Dec 3, 2015
@bpasero
Copy link
Member

bpasero commented Dec 3, 2015

Sounds like a good area for a PR.

@rstat1
Copy link

rstat1 commented Dec 7, 2015

If no one else is working on this, I'll take it.

@bpasero
Copy link
Member

bpasero commented Dec 7, 2015

👍

@egamma
Copy link
Member

egamma commented Dec 7, 2015

It isn't on the December plan #917

@be5invis
Copy link
Contributor Author

be5invis commented Dec 7, 2015

And well to avoid some inconvenience you can add a command to show the menu temporary.

@rstat1
Copy link

rstat1 commented Dec 7, 2015

@egamma should I wait until January then? Or no?

@bpasero
Copy link
Member

bpasero commented Dec 7, 2015

@rstat1 this just means we will not work on it so feel free to do the PR.

@rstat1
Copy link

rstat1 commented Dec 8, 2015

So pull request #1090 is my attempt at adding this feature, please take a look and feel free to yell at me if I did it wrong :P

@egamma egamma modified the milestone: Backlog Dec 10, 2015
@bpasero bpasero self-assigned this Dec 18, 2015
@bpasero bpasero modified the milestones: Jan 2016, Backlog Dec 18, 2015
@bpasero
Copy link
Member

bpasero commented Dec 18, 2015

This is Windows only.

@bpasero bpasero changed the title There should be an option to hide the menu bar. Windows: There should be an option to hide the menu bar. Dec 18, 2015
@ristomatti
Copy link
Contributor

@bpasero I couldn't find this from the backlog anymore. Is this issue still open? Also I didn't quite follow why the issue title was changed to target Windows only? I would really like to see this feature in Linux too!

One of the biggest reasons I like to use minimalistic editors is that I hate wasting screen space for stuff I will most certainly use through a keyboard or command palette. In case this is closed/removed from the backlog, should I create another feature request for it?

@bpasero
Copy link
Member

bpasero commented Dec 20, 2015

From my testing the function I used to hide the menu did not work on Linux.

@ristomatti
Copy link
Contributor

I figured that from the context but I don't see why that would affect this issue. The original issue reported by @be5invis had no platform defined IIRC. Maybe there's something I'm missing here but to me it seems like this issue is still a valid feature request (at least for the other platforms), and therefore should not be closed as the issue is not resolved.

I can report this separately as a multi-platform feature request in case that helps in some way (as this issue is already closed)?

@ristomatti
Copy link
Contributor

I was tipped about the User Voice service on an another issue. In case it's of any help mapping GitHub issues and User Voice feature requests, here's a matching User Voice feature request: https://visualstudio.uservoice.com/forums/293070-visual-studio-code/suggestions/8345181-hide-menu-bar

@bpasero
Copy link
Member

bpasero commented Dec 21, 2015

Feel free to open a new feature request for linux

@bpasero
Copy link
Member

bpasero commented Dec 21, 2015

Actually it seems that some Linux distros might support this feature so i could enable it for Linux too, but I cannot get it to work on Ubuntu 15 at least. @ristomatti would you be willing to try it out on your Linux distro?

@ristomatti
Copy link
Contributor

@bpasero I'd be happy to do that. Just point me to the right direction what I need to do. Should I setup a Code development environment and then apply the pull request as a patch? Or is there a simpler way to do this?

@bpasero
Copy link
Member

bpasero commented Dec 21, 2015

@ristomatti yes if you can setup VS Code to run out of sources on your Linux box, you can basically just flip the boolean flags for isWindows to isLinux here to give it a try: c34d2e7

@egamma egamma mentioned this issue Jan 6, 2016
59 tasks
@bpasero bpasero removed the help wanted Issues identified as good community contribution opportunities label Jan 25, 2016
@egamma egamma mentioned this issue Feb 1, 2016
97 tasks
@LiZhenNet
Copy link

I have hidden Menu Bar,but I do not konwn how to show it?keyboard shortcut?

@bpasero
Copy link
Member

bpasero commented Mar 14, 2016

@LiZhenNet you can press the Alt key to bring it back briefly or F1 to find the command to toggle the setting back.

@ghost
Copy link

ghost commented Mar 31, 2016

You should show a hint about "Alt" every time user hides menu. I just waste an hour searching for how to unhide the menu.

@bpasero
Copy link
Member

bpasero commented Mar 31, 2016

We do that for our 1.0 release. You can always access any commands (including the menu toggle) from the command palette (Ctrl+Shift+P).

@cnd
Copy link

cnd commented Apr 14, 2016

may you point where I can correct translation of this menu action

@bpasero
Copy link
Member

bpasero commented Apr 15, 2016

You can file a bug on it.

@ig0rsky
Copy link

ig0rsky commented Jan 9, 2017

How do I overwrite the behaviour of the alt key??

Tried this but didn't work:
keybinding.json:
{
"key": "alt",
"command": "",
}

@bpasero
Copy link
Member

bpasero commented Jan 10, 2017

@NiggyWizzyWoz our next release adds a new setting window.menuBarVisibility that you can set to hidden to not show it even when you press Alt.

You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

@paradigmist
Copy link

paradigmist commented Jan 25, 2017

@bpasero I have tried your solution on the vscode insider, but the menu bar is still invoked by alt key.

@bpasero
Copy link
Member

bpasero commented Jan 25, 2017

@paradigmist and how did you change the setting? to what value?

@paradigmist
Copy link

@bpasero

{
    "window.menuBarVisibility": "hidden"
}

@bpasero
Copy link
Member

bpasero commented Feb 10, 2017

It should work from our current insider build (1.10.0).

@vfhky
Copy link

vfhky commented Jul 31, 2017

You can edit the settings.json and append the configs blow.
"window.menuBarVisibility": "toggle"
Then you can use the key of Alt to switch.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.