Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for hover contributions #53

Closed
alexkreidler opened this issue Apr 11, 2020 · 0 comments · May be fixed by #77
Closed

Add tests for hover contributions #53

alexkreidler opened this issue Apr 11, 2020 · 0 comments · May be fixed by #77
Assignees
@aeschli
Labels
feature-request Request for new features or functionality
Milestone
November 2020

Comments

@alexkreidler
Copy link
Contributor

The current tests use schema contributions to test various schema features.

However there are no tests for hover contributions, which poses a problem if one wanted to write alternative hover providers.

The relevant code is here:

vscode-json-languageservice/src/services/jsonHover.ts

Lines 54 to 60 in fabbc80

for (let i = this.contributions.length - 1; i >= 0; i--) {
const contribution = this.contributions[i];
const promise = contribution.getInfoContribution(document.uri, location);
if (promise) {
return promise.then(htmlContent => createHover(htmlContent));
}
}

apexskier added a commit to apexskier/vscode-json-languageservice that referenced this issue Oct 1, 2020
@apexskier
Add test for hover contributions
89eb0dd 
Fixes microsoft#53
@apexskier apexskier mentioned this issue Oct 1, 2020
Open
@aeschli aeschli added this to the November 2020 milestone Nov 12, 2020
@aeschli aeschli added the feature-request Request for new features or functionality label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
November 2020
2 participants
@aeschli @alexkreidler