-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[json] create links for values of format uri-reference
#128971
[json] create links for values of format uri-reference
#128971
Comments
Does that exist already? |
I've never seen it used sadly (as above) and looking at the reference (https://cswr.github.io/JsonSchema/spec/basic_types/) seems to also support the fact that it doesn't have this. On the other hand there are references that state that this does exist using an additional (optional) I'm currently unable to check whether vscode actually respects/supports these different formats, do you happen to know? If it is supported (and this would be preferable), then the issue clearly lies with the schema authors :) |
Yes. we support most of the format kinds. We have automatic link rendering if a value is in the URL form (scheme://authority/...). That's cheap as we can generate this without a need to test if the path exists. If you want to work on this and add link support for all elements that have format |
uri-reference
Hi, sorry for the delay If I understood you correctly, it is true that vscode currently doesn't use the That would explain the issue in the vscode-yaml plugin aswell: redhat-developer/vscode-yaml#559 (comment) |
but not for link detection |
When authoring json it'd be great to have a richer experience when referencing other files, without having the overhead of defining a
file://
URI whenever this is required (see example below).I would expect this behaviour by standard when the schema is defining the values as file-references, this is also related to my more pertinent issue in the vscode-yaml repository concerning the handling of k8s kustomize resources (vscode-yaml#559)
The text was updated successfully, but these errors were encountered: