From 2878725633841f0e63499bd51b1e26291c104884 Mon Sep 17 00:00:00 2001 From: Garrett Campbell <86264750+gcampbell-msft@users.noreply.github.com> Date: Wed, 14 Feb 2024 14:40:41 -0500 Subject: [PATCH] Fix test issue #3589 (#3590) * fix test * update changelog * update changelog --- CHANGELOG.md | 8 +++++++- src/ctest.ts | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f1209bcd3..0bc97cf89 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,12 @@ # What's New? -## 1.17 +## 1.17.16 + +Bug Fixes: + +- Fix an issue where we weren't able to run tests when not using Presets. [#3589](https://github.com/microsoft/vscode-cmake-tools/issues/3589) + +## 1.17.15 Features: diff --git a/src/ctest.ts b/src/ctest.ts index 671baa6c1..40a132daf 100644 --- a/src/ctest.ts +++ b/src/ctest.ts @@ -318,7 +318,7 @@ export class CTestDriver implements vscode.Disposable { const ctestArgs = await this.getCTestArgs(driver, customizedTask, testPreset); - if (!driver.testPreset) { + if (!driver.testPreset && driver.useCMakePresets) { log.error('test.preset.not.set', 'Test preset is not set'); return -3; }