Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client proxy generation at compile time #746

Open
ForkBug opened this issue Nov 25, 2021 · 3 comments
Open

Client proxy generation at compile time #746

ForkBug opened this issue Nov 25, 2021 · 3 comments

Comments

@ForkBug
Copy link

ForkBug commented Nov 25, 2021

Client proxy generation may be done at compile time via source generator.
This modification could improve performance and add strong typed request for AOT environment(such as xamarin.ios)

@AArnott
Copy link
Member

AArnott commented Nov 29, 2021

This is true. The perf improvement would only be to startup time -- overall throughput would not be affected.

If we do this, we'd probably add a version constant to the generated class so that at runtime the library may choose to ignore the AOT generated class when it's too old to be used by the current version of the library, since these proxies do occasionally change.

@moustakakisCon
Copy link

hello, I am integrating streamjsonrpc in a unity game and I am looking to use strong typed request, but System.Reflection.Emit.AssemblyBuilder.DefineDynamicAssembly is not supported in IL2CPP scripting backend.

Is there any chance this enhancement will be implemented in the (not so far) future?

@AArnott
Copy link
Member

AArnott commented Mar 7, 2024

Unlikely. Strict AOT environments like unity are decidedly out of scope for anything likely to be prioritized in StreamJsonRpc for the forseeable future. Thanks for asking, @moustakakisCon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants