GitHub CI fails to attach test results

[sharwell]

The test step reports this:

Results File: D:\a\vs-extension-testing\vs-extension-testing\src\Microsoft.VisualStudio.Extensibility.Testing.Xunit.IntegrationTests\TestResults\runneradmin_fv-az177-418_2021-08-02_15_11_36.trx

...

Results File: D:\a\vs-extension-testing\vs-extension-testing\src\Microsoft.VisualStudio.Extensibility.Testing.Xunit.Legacy.IntegrationTests\TestResults\runneradmin_fv-az177-418_2021-08-02_15_11_39.trx

But the Upload testResults step reports this:

Error: Path does not exist D:\a\vs-extension-testing\vs-extension-testing\obj\_artifacts\testResults
Error: Exit code 1 returned from process: file name 'c:\runners\2.279.0\bin\Runner.PluginHost.exe', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'.

/cc @AArnott this might be a problem with Library.Template

[AArnott]

It works in Library.Template.
Your "Collect artifacts" step is missing the testResults in its final table. This row appears in the Library.Template equivalent.

Your fix here looks good. I guess we need more verbose logging of that script to understand why it didn't collect anything.