-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libspng]: New port #35412
[libspng]: New port #35412
Conversation
19e3d20
to
73687bd
Compare
73687bd
to
b320ba9
Compare
b320ba9
to
cf3046f
Compare
Usage test failed in x64-windows and x64-windows-static triplet:
This issue could be fixed by adding
The issue is that under the x64-windows-static triplet, the generated target name is
|
Currently, when use `find_package(SPNG CONFIG REQUIRED)` , an error occurred. ``` CMake Error at vcpkg/installed/x64-windows/share/spng/SPNGConfig.cmake:27 (find_dependency): Unknown CMake command "find_dependency". ``` Reference: microsoft/vcpkg#35412
Thanks for your review. I've fixed those issues and opened a PR to upstream randy408/libspng#263 Tested usage on x64-windows |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.