Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMODE not entirely correct #98

Open
Sympatron opened this issue Apr 14, 2021 · 0 comments
Open

WMODE not entirely correct #98

Sympatron opened this issue Apr 14, 2021 · 0 comments

Comments

@Sympatron
Copy link

Technically the following line would have to set NVMCTRL_CTRLA_WMODE_MAN_Val instead of NVMCTRL_CTRLA_WMODE_MAN, because the latter is already shifted and therefore not meant to be written to the bitfield. This only worked, because NVMCTRL_CTRLA_WMODE_MAN_Val is 0x0, otherwise this would not have worked.

NVMCTRL->CTRLA.bit.WMODE = NVMCTRL_CTRLA_WMODE_MAN;

I know this is nitpicky since it works, but this code would break down if somebody used it as a reference and tried to use another mode.

Sympatron added a commit to Sympatron/uf2-samdx1 that referenced this issue Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant