Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

[request] Append gitHead to package.json #458

Open
teppeis opened this issue May 5, 2018 · 2 comments
Open

[request] Append gitHead to package.json #458

teppeis opened this issue May 5, 2018 · 2 comments

Comments

@teppeis
Copy link

teppeis commented May 5, 2018

Currently published @​types packages don't include git revision of DefinitelyTyped repo, so we cannot get to know the exact diff between previous version and new one without actually comparing downloaded packages.

npm publish appends gitHead field to package.json: npm/read-package-json#7

I think the field is very useful for @​types packages.

@teppeis
Copy link
Author

teppeis commented May 6, 2018

Usecase: automated dependency updates service like Renovate

It creates PR to update deps with changelog: ex) teppeis/bind.ts#31
But DefinitelyTyped repo doesn't have git tag for each package and @​types package doesn't have gitHead prop, it cannot generate changelog: ex) teppeis/bind.ts#42

@felixfbecker
Copy link

We also need this property at Sourcegraph to provide go-to-definition to the DefinitelyTyped repository at the correct revision.

felixfbecker added a commit to felixfbecker/types-publisher that referenced this issue Dec 7, 2018
This is a field normally added automatically by npm publish.

Closes microsoft#458
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants