Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile.windows #1489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Dockerfile.windows #1489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions presidio-analyzer/Dockerfile.windows
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.9-windowsservercore
FROM python:3.12-windowsservercore-ltsc2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you choose this base image?

Copy link
Contributor Author

@markvantilburg markvantilburg Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this website there are only 2 official docker images:

https://hub.docker.com/_/python?tab=tags&page=1&name=3.8.2&ordering=-name

3.12.7-windowsservercore-ltsc2022, 3.12-windowsservercore-ltsc2022⁠

3.12.7-windowsservercore-1809, 3.12-windowsservercore-1809⁠

Should i put 1809 instead of the ltsc2022 version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an official version for python 3.9? 3.12 is still in "bugfix" status: https://devguide.python.org/versions/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as i see v3.12 is the first with official windows images. https://github.com/docker-library/python

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about these? https://hub.docker.com/r/microsoft/windows-cssc-python


ARG NLP_CONF_FILE=presidio_analyzer/conf/default.yaml
ARG ANALYZER_CONF_FILE=presidio_analyzer/conf/default_analyzer.yaml
Expand All @@ -19,8 +19,11 @@ RUN ./vc_redist.x64.exe /quiet /install

COPY ./pyproject.toml /app/pyproject.toml
COPY ./README.md /usr/bin/${NAME}/
RUN pip install --upgrade pip
RUN pip install poetry; poetry install --no-root --only=main -E server -E transformers
WORKDIR /Python
RUN python.exe -m pip install --upgrade pip
RUN pip install poetry;
WORKDIR /app
RUN poetry install --no-root --only=main -E server -E transformers

# install nlp models specified in NLP_CONF_FILE
COPY ./install_nlp_models.py .
Expand Down