Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed default aggregation_strategy to max #1342

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Changed default aggregation_strategy to max #1342

merged 3 commits into from
Mar 25, 2024

Conversation

omri374
Copy link
Contributor

@omri374 omri374 commented Mar 25, 2024 •
edited
Loading

Change Description

Changing the way transformers are aggregating entities from simple to max, as it has a slightly better recall on a test dataset.

Issue reference

This PR partially addresses issue #1262

@omri374 omri374 marked this pull request as ready for review March 25, 2024 08:01
@omri374 omri374 merged commit 49a996d into main Mar 25, 2024
31 checks passed
@omri374 omri374 deleted the omri/aggregation_strategy branch March 25, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@omri374