fix: clean up videos after each test #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Apr 16, 2024
| else: | ||
| for page in self._all_pages: | ||
| # Can be changed to "if page.video" once https://github.com/microsoft/playwright-python/pull/2410 is released and used. | ||
| if video_option in ["on", "retain-on-failure"]: |
There was a problem hiding this comment.
maybe try/catch instead?
Ideally we look at the context options, but they are not exposed. Since some contexts could have video enabled and some not, try/catch seems the most reasonable.
dgozman
approved these changes
Apr 16, 2024
mxschmitt
force-pushed
the
bugfix/clean-up-videos2
branch
from
cc8b7d1 to
6389ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates microsoft/playwright-python#2410