Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HyperV changes for Core #1149

Open
wants to merge 1 commit into
base: dev/202405
Choose a base branch
from

Conversation

kenlautner
Copy link
Contributor

Description

This PR adds restore TPL requirements and HyperV adjustments. The relevant commits from 202311 are listed here:

c3acc1f

Descriptions for these commits are as follows:


Add HyperV changes for Core.
Related work items: #15630331, #16977641


  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested with CI

Integration Instructions

N/A

HyperV changes for Core.

Related work items: #15630331, #16977641
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.59%. Comparing base (23f8354) to head (fdabf6c).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1149   +/-   ##
===========================================
  Coverage        1.59%    1.59%           
===========================================
  Files            1448     1448           
  Lines          362490   362490           
  Branches         5632     5632           
===========================================
  Hits             5776     5776           
  Misses         356607   356607           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 5.42% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of the current commit (fdabf6c), the only non-whitespace related change seems to be adding the prototype for EnableInterruptsAndSleep() to BaseLib.h. That doesn't align with the PR description. Is that what you expected to have here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants