[Bug]: tools_def parser does not support inline comment #1193
Labels
state:needs-owner
Needs an issue owner to be assigned
state:needs-triage
Needs to triaged to determine next steps
type:bug
Something isn't working
urgency:low
Little to no impact
Is there an existing issue for this?
Current Behavior
The current tools_def parser does not take inline comments as expected, and treating it as an additional argument and piped into the final build arguments.
We have been lucky as most of the inline comments are hidden behind existing comments. And other toolchains like CLANG do not get built often.
Expected Behavior
Properly treat inline comments as legit comments instead of piping into the final comments.
Steps To Reproduce
Add some inline comments (i.e.
# MU_CHANGE
) to the tools_def.txt in conf folder for the target build, i.e. PP_FLAGS. The build could break with#: No such file or directory
.Build Environment
Version Information
Top of tree.
Urgency
Low
Are you going to fix this?
Someone else needs to fix it
Do you need maintainer feedback?
No maintainer feedback needed
Anything else?
No response
The text was updated successfully, but these errors were encountered: