[SDN-VNET] Protobuf changes #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijosmsft
force-pushed
the
user/nijos/sdnvnet
branch
from
dc62d39
to
5a339a2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sbgms
reviewed
Nov 7, 2024
| @@ -358,3 +358,8 @@ enum CloudInitDataSource { | |||
| NoCloud = 0; | |||
| Azure = 1; | |||
| } | |||
|
|
|||
| message ApiVersion { | |||
There was a problem hiding this comment.
Minor: Ideally it should be Major.Minor.Build.Revision.
There was a problem hiding this comment.
agree, i didnt want to add fields to protobuf that we are not using not.
sbgms
previously approved these changes
Nov 7, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes