Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPDK: Add 32bit test #3489

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

DPDK: Add 32bit test #3489

wants to merge 12 commits into from

Conversation

mcgov
Copy link
Collaborator

@mcgov mcgov commented Oct 28, 2024

Add a test which compiles DPDK as a 32bit application before run. Implements basic build and send_receive tests.

Required a little fiddling with meson and pkgconfig to ensure the 32bit libraries are used when needed.

@mcgov
Copy link
Collaborator Author

mcgov commented Oct 29, 2024

@squirrelsc I'm getting a ton of mypy errors which are due to the old version we're using :\
Any objections to upgrading to a slightly more recent version?

@squirrelsc
Copy link
Member

@squirrelsc I'm getting a ton of mypy errors which are due to the old version we're using :\ Any objections to upgrading to a slightly more recent version?

We don't have a plan to upgrade mypy yet, it's not a trivial and safe work.

@mcgov
Copy link
Collaborator Author

mcgov commented Oct 29, 2024

@squirrelsc I'm getting a ton of mypy errors which are due to the old version we're using :\ Any objections to upgrading to a slightly more recent version?

We don't have a plan to upgrade mypy yet, it's not a trivial and safe work.

Definitely not trivial, tons of errors specifically in the aws and azure sut_orchestrator code 😵‍💫

@mcgov mcgov force-pushed the mcgov/32b branch 3 times, most recently from d435fd6 to f798f14 Compare October 30, 2024 19:32
Allowing extension of the class for the 32bit build
Allow building rdma-core and dpdk as 32bit applications before test.
Add the 32bit test.

This is a beefy commit because we must extend the Installer class
to support 32bit builds. This means adding invalid arch checks,
adding arch checks to the DependencyInstaller, adding
changes to PKG_CONFIG_PATH and allowing updating environment variables
everywhere.

The result is that we can install DPDK and RDMA core and run their
32bit versions to test basic send/receive stuff.
@mcgov mcgov marked this pull request as ready for review November 19, 2024 19:10
@mcgov
Copy link
Collaborator Author

mcgov commented Nov 19, 2024

@squirrelsc I've worked out the mypy issues. Should be all good now.

@squirrelsc
Copy link
Member

@LiliDeng LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants