Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for missing translations #5607

Closed
thewahome opened this issue Oct 16, 2024 · 1 comment · Fixed by #5604
Closed

Check for missing translations #5607

thewahome opened this issue Oct 16, 2024 · 1 comment · Fixed by #5604
Labels
type:feature New experience request vscode-extension Work related to the vscode-extension WIP

Comments

@thewahome
Copy link
Contributor

Is your feature request related to a problem? Please describe the problem.

When maintaining the vscode extension, it's easy to forget to update the translation files after a feature is done. It would help us to add a new check to show us the missing translations available

Client library/SDK language

None

Describe the solution you'd like

Introduce a script file that checks the missing translations and generates a readable list for the items that need attention. Preferably in a table and available in CI/CD

Additional context

No response

@thewahome thewahome added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request vscode-extension Work related to the vscode-extension labels Oct 16, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Oct 16, 2024
@musale
Copy link
Contributor

musale commented Oct 16, 2024

This is a good idea. I have some thoughts:

  • Have labels that you can attach to a PR to reduce workflow runs. Adding these labels to a PR triggers the workflow. If a PR is not introducing/using translation strings, there's no point to run the workflow.
  • Instead of putting the output of untranslated strings in an artifacts file, post a comment on the PR with the table. Consecutive updates to the PR should check if that comment exists and update it accordingly. This should help to reduce multiple comments.

@andrueastman andrueastman removed the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Oct 16, 2024
@andrueastman andrueastman moved this from Needs Triage 🔍 to Proposed 💡 in Kiota Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Proposed 💡 to Done ✔️ in Kiota Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New experience request vscode-extension Work related to the vscode-extension WIP
Projects
Status: Done ✔️
Development

Successfully merging a pull request may close this issue.

3 participants