From be094981efaaaec96b5dd9761a921a9bb1c3f6d6 Mon Sep 17 00:00:00 2001 From: Matthew John Cheetham Date: Thu, 12 Dec 2024 10:35:32 +0000 Subject: [PATCH] build-git-installers.yml: drop cv2pdb exist test Since https://github.com/rainers/cv2pdb/pull/66, the cv2pdb tool no longer needs assistance to locate the mspdb140.dll library, as it now uses `vswhere` which is found on all hosted runners. For Windows/ARM64 builds we're using self-hosted (1ES pool) runners which may not have `vswhere`, _but_ this is OK since the clang builds can produce PDBs natively anyway. Signed-off-by: Matthew John Cheetham --- .github/workflows/build-git-installers.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/build-git-installers.yml b/.github/workflows/build-git-installers.yml index 9ae95f20bad4b3..440b908fde4476 100644 --- a/.github/workflows/build-git-installers.yml +++ b/.github/workflows/build-git-installers.yml @@ -122,11 +122,6 @@ jobs: # Make sure that there is a `/usr/bin/git` that can be used by `makepkg-mingw` printf '#!/bin/sh\n\nexec /mingw64/bin/git.exe "$@"\n' >/usr/bin/git && - # Restrict `PATH` to MSYS2 and to Visual Studio (to let `cv2pdb` find the relevant DLLs) - PATH="/mingw64/bin:/usr/bin:/C/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64:/C/Windows/system32" - - type -p mspdb140.dll || exit 1 - sh -x /usr/src/build-extra/please.sh build-mingw-w64-git --only-64-bit --build-src-pkg -o artifacts HEAD && if test -n "$GPGKEY" then