FluentNumberField min and max value validation #350
Closed
Andras-Csanyi
started this conversation in
General
Replies: 1 comment 2 replies
-
Yes, would be good to have that kind of input validation. Please include! |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi @vnbaaij,
I started writing test cases against FluentNumberField for increasing the coverage of components using
FluentInputBase<TValue>
and following up my previous PR (#341). I see that the min and max values are either a, provided or b, coming from the given type. What I realised is the following:int
I can provide higher value than2147483647
min
than themax
(I haven't tried what is happening here)What is your take in this case? If you think this level of input validation is nice to have I'm happy to include them in my PR.
Beta Was this translation helpful? Give feedback.
All reactions