From f5562865dc1ecad3263925a66003c43a4ce3fc4d Mon Sep 17 00:00:00 2001 From: Oliver Limberg Date: Wed, 24 Apr 2019 18:35:02 +0200 Subject: [PATCH] moved shared valued from module Fastlane::Helper to Fastlane::Actions this seems to be the default module to define shared values according to all other fastlane actions --- .../appcenter/actions/appcenter_upload_action.rb | 5 +++++ .../plugin/appcenter/helper/appcenter_helper.rb | 13 ++++--------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/fastlane/plugin/appcenter/actions/appcenter_upload_action.rb b/lib/fastlane/plugin/appcenter/actions/appcenter_upload_action.rb index 2ea2277..be7218a 100644 --- a/lib/fastlane/plugin/appcenter/actions/appcenter_upload_action.rb +++ b/lib/fastlane/plugin/appcenter/actions/appcenter_upload_action.rb @@ -4,6 +4,11 @@ module Constants MAX_RELEASE_NOTES_LENGTH = 5000 end + module SharedValues + APPCENTER_DOWNLOAD_LINK = :APPCENTER_DOWNLOAD_LINK + APPCENTER_BUILD_INFORMATION = :APPCENTER_BUILD_INFORMATION + end + class AppcenterUploadAction < Action # run whole upload process for dSYM files def self.run_dsym_upload(params) diff --git a/lib/fastlane/plugin/appcenter/helper/appcenter_helper.rb b/lib/fastlane/plugin/appcenter/helper/appcenter_helper.rb index 82e7914..98d4724 100644 --- a/lib/fastlane/plugin/appcenter/helper/appcenter_helper.rb +++ b/lib/fastlane/plugin/appcenter/helper/appcenter_helper.rb @@ -1,10 +1,5 @@ module Fastlane module Helper - module SharedValues - APPCENTER_DOWNLOAD_LINK = :APPCENTER_DOWNLOAD_LINK - APPCENTER_BUILD_INFORMATION = :APPCENTER_BUILD_INFORMATION - end - class AppcenterHelper # create request @@ -260,8 +255,8 @@ def self.update_release(api_token, owner_name, app_name, release_id, release_not UI.message("DEBUG: #{JSON.pretty_generate(release)}") if ENV['DEBUG'] - Actions.lane_context[SharedValues::APPCENTER_DOWNLOAD_LINK] = download_url - Actions.lane_context[SharedValues::APPCENTER_BUILD_INFORMATION] = release + Actions.lane_context[Fastlane::Actions::SharedValues::APPCENTER_DOWNLOAD_LINK] = download_url + Actions.lane_context[Fastlane::Actions::SharedValues::APPCENTER_BUILD_INFORMATION] = release UI.message("Release #{release['short_version']} was successfully updated") @@ -301,8 +296,8 @@ def self.add_to_group(api_token, owner_name, app_name, release_id, group_id, man UI.message("DEBUG: received release #{JSON.pretty_generate(release)}") if ENV['DEBUG'] - Actions.lane_context[SharedValues::APPCENTER_DOWNLOAD_LINK] = download_url - Actions.lane_context[SharedValues::APPCENTER_BUILD_INFORMATION] = release + Actions.lane_context[Fastlane::Actions::SharedValues::APPCENTER_DOWNLOAD_LINK] = download_url + Actions.lane_context[Fastlane::Actions::SharedValues::APPCENTER_BUILD_INFORMATION] = release UI.message("Public Download URL: #{download_url}") if download_url