Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the IOCTL numbers so that ebpfapi.dll for x64 and x64-NativeOnly are cross-compatible. #3305

Merged
merged 14 commits into from
Mar 5, 2024
Merged

Fix the IOCTL numbers so that ebpfapi.dll for x64 and x64-NativeOnly are cross-compatible. #3305

merged 14 commits into from
Mar 5, 2024

Conversation

saxena-anurag
Copy link
Contributor

@saxena-anurag saxena-anurag commented Feb 27, 2024 •
edited
Loading

Fixes #3126

Description

This PR fixes the IOCTL numbers so that ebpfapi.dll for x64 and x64-NativeOnly are cross-compatible.

Changes:

  1. Enable all the IOCTL numbers and block the JIT / interpret related IOCTLs in ebpfcore.
  2. Add new tests for the new enabled IOCTL paths. Since these tests are in unit_tests, and unit_tests are today not run for NativeOnly* builds, added unit_tests execution for NativeOnly* builds also.
  3. Some other minor fixes.

Testing

Added new tests.

Documentation

No

Installation

No.

@saxena-anurag saxena-anurag changed the title backup [DRAFT] Feb 27, 2024
@saxena-anurag saxena-anurag changed the title [DRAFT] Fix the IOCTL numbers so that ebpfapi.dll for x64 and x64-NativeOnly are cross-compatible. Mar 1, 2024
@saxena-anurag saxena-anurag marked this pull request as ready for review March 1, 2024 02:48
dthaler
dthaler approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@saxena-anurag saxena-anurag enabled auto-merge March 4, 2024 22:57
@saxena-anurag saxena-anurag added this pull request to the merge queue Mar 5, 2024
Merged via the queue into microsoft:main with commit 5011c71 Mar 5, 2024
80 checks passed
@saxena-anurag saxena-anurag deleted the user/anusa/issue_3126 branch March 5, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtrevi gtrevi gtrevi approved these changes

@dthaler dthaler dthaler approved these changes

@poornagmsft poornagmsft Awaiting requested review from poornagmsft poornagmsft is a code owner

@Alan-Jowett Alan-Jowett Awaiting requested review from Alan-Jowett Alan-Jowett is a code owner

@shankarseal shankarseal Awaiting requested review from shankarseal shankarseal is a code owner

@dv-msft dv-msft Awaiting requested review from dv-msft dv-msft is a code owner

@shpalani shpalani Awaiting requested review from shpalani shpalani is a code owner

@matthewige matthewige Awaiting requested review from matthewige matthewige is a code owner

@mtfriesen mtfriesen Awaiting requested review from mtfriesen mtfriesen is a code owner

@rectified95 rectified95 Awaiting requested review from rectified95 rectified95 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the IOCTL numbers so that ebpfapi.dll for x64 and x64-NativeOnly are cross-compatible.
3 participants
@saxena-anurag @dthaler @gtrevi