Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE-2024-37891 for tensorflow and python-pip :3.0 #11181

Open
wants to merge 4 commits into
base: fasttrack/3.0
Choose a base branch
from

Conversation

KavyaSree2610
Copy link
Contributor

@KavyaSree2610 KavyaSree2610 commented Nov 22, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
Does this affect the toolchain?

YES

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@KavyaSree2610 KavyaSree2610 marked this pull request as ready for review November 22, 2024 10:59
@KavyaSree2610 KavyaSree2610 requested a review from a team as a code owner November 22, 2024 10:59
@KavyaSree2610 KavyaSree2610 changed the title Fix CVE-2024-37891 for tensorflow and python-pip Fix CVE-2024-37891 for tensorflow and python-pip :3.0 Nov 22, 2024
We do not ship pip as part of the tensorflow package, so the CVE for it needs to be disputed not patched
We do not ship pip as part of the tensorflow package, so the CVE for it needs to be disputed not patched
Copy link
Contributor

@mbykhovtsev-ms mbykhovtsev-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the tensorflow patch changes because we do not ship pip as part of the tensorflow package, so the CVE for it needs to be disputed not patched. But the python-pip patch looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants