Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Patch CVE-2024-2398, CVE-2024-7264 in bundled curl and CVE-2024-28182 in bundled nghttp2 #11170

Open
wants to merge 1 commit into
base: fasttrack/2.0
Choose a base branch
from

Conversation

vinceaperri
Copy link
Contributor

@vinceaperri vinceaperri commented Nov 20, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

CVE fixes for cmake's bundled curl and nghttp2

Change Log
  • Add patches to fix CVE-2024-2398 and CVE-2024-7264 in cmake's bundled curl
  • Add patch to fix CVE-2024-28182 in cmake's bundled nghttp2
Does this affect the toolchain?

YES

Links to CVEs
Test Methodology
  • Pipeline build id: 680135

@vinceaperri vinceaperri requested a review from a team as a code owner November 20, 2024 23:14
@vinceaperri vinceaperri changed the title cmake: Patch CVE-2024-2398 in bundled curl cmake: Patch HIGH CVE-2024-2398 in bundled curl Nov 20, 2024
@vinceaperri vinceaperri force-pushed the vinceaperri/fasttrack/2.0-cmake branch from 135b927 to 9349601 Compare November 21, 2024 14:36
@vinceaperri vinceaperri changed the title cmake: Patch HIGH CVE-2024-2398 in bundled curl cmake: Patch HIGH CVE-2024-2398 in bundled curl and MEDIUM CVE-2024-28182 in bundled nghttp2 Nov 21, 2024
@vinceaperri vinceaperri force-pushed the vinceaperri/fasttrack/2.0-cmake branch from 9349601 to d16de56 Compare November 21, 2024 15:14
@vinceaperri vinceaperri changed the title cmake: Patch HIGH CVE-2024-2398 in bundled curl and MEDIUM CVE-2024-28182 in bundled nghttp2 cmake: Patch CVE-2024-2398, CVE-2024-7264 in bundled curl and CVE-2024-28182 in bundled nghttp2 Nov 21, 2024
@@ -29,6 +29,10 @@ Patch14: CVE-2023-27538.patch
Patch15: CVE-2023-27535.patch
Patch16: CVE-2023-23916.patch
Patch17: CVE-2023-46218.patch
Patch18: CVE-2024-2398.patch
Patch19: CVE-2024-28182.patch
Patch20: CVE-2024-7264-1.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might cause issues with CVE scanning tools (having -1 and -2 patch files). Can you combine them to a single file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants