Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

isValidAzureBoardsUrl check for visualstudio.com URL #56

Open
alexcnichols opened this issue May 17, 2019 · 1 comment
Open

isValidAzureBoardsUrl check for visualstudio.com URL #56

alexcnichols opened this issue May 17, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@alexcnichols
Copy link
Contributor

azure-boards-vscode/src/configuration/url.ts

Line 6 in 026eb8a

(url.startsWith("https://") && url.indexOf(".visualstudio.com") >= 0)

Seems like there could be URLs that meet this check but aren't actual Azure DevOps Services URLs. https://asdf.visualstudio.com.badactor.com

Any consequence of that?
@cschleiden
Copy link
Contributor

Don't think so, but I agree, let's tighten it up

@alexcnichols alexcnichols added the bug Something isn't working label Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cschleiden @alexcnichols