Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Chart: Extract bugChart #4813

Merged
merged 15 commits into from
Jul 7, 2024

Conversation

StephanTLavavej
Copy link
Member

🗺️ Overview

In addition to 5 weekly updates, this contains dependency updates including breaking changes in primer/css.

While dealing with those breaking changes, I lost the ability to have a dark red color. That prompted me to notice that the bugs/issues were really cluttering up the chart as our history has grown. Earlier (in #4235), we hid the lines by default to mitigate this, but with fewer colors available it was even more of a mess. So, I split out another chart, which makes everything much clearer.

📜 Commits

  • Load primitives.min.css to work around Primitives variables missing in bundled css primer/css#2648.
  • Rename colors, part 1.
    • Old color names were removed, so we have to use the new names.
    • Adjust type ColorName accordingly.
    • 'Old Bugs' used '--color-scale-red-7', which was problematic because it didn't respond to light/dark. Replace it with the "attention" color, since it doesn't overlap with 'Skipped Libcxx Tests'. Adjust the Counter in index.html accordingly.
    • Change the Counters in index.html for Pull Requests and Combined Age to use normal classes from Primer CSS.
      This results in some change for dark mode, but it's still sufficiently clear.
  • Rename colors, part 2.
    • This updates the CSS classes in index.html to use the new names. This isn't strictly necessary right now, but it's a good idea for the future.
  • Extract bugChart, part 1.
    • Drop the line "This chart has two vertical axes."
    • This is a full-history chart, using timeframe_idx.
  • Extract bugChart, part 2.
    • We don't need to auto-hide lines anymore, but leave the machinery implemented.
    • Move the bugChart's largeAxis to the right.
    • Now that we have different charts, change line/counter colors to improve clarity:
      • Old Bugs will be purple ("done").
      • C++26 will be blue ("accent").
  • Extract bugChart, part 3.
    • Now that each chart has a single axis, we can simplify their explanations.
  • Reorganize explanations.
    • Move "For all lines, fewer is better." down, as it's not important.
    • Centralize the explanation of how features and LWG issue resolutions are regularly voted in.
  • No LWG issues are labeled as "blocked" anymore.

📉 Live preview: stephantlavavej.github.io/STL/

Old color names were removed, so we have to use the new names.

Adjust `type ColorName` accordingly.

'Old Bugs' used '--color-scale-red-7', which was problematic because it didn't respond to light/dark.
Replace it with the "attention" color, since it doesn't overlap with 'Skipped Libcxx Tests'.
Adjust the Counter in index.html accordingly.

Change the Counters in index.html for Pull Requests and Combined Age to use normal classes from Primer CSS.
This results in some change for dark mode, but it's still sufficiently clear.
This updates the CSS classes in index.html to use the new names.
This isn't strictly necessary right now, but it's a good idea for the future.
Drop the line "This chart has two vertical axes."

This is a full-history chart, using `timeframe_idx`.
We don't need to auto-hide lines anymore, but leave the machinery implemented.

Move the bugChart's largeAxis to the right.

Now that we have different charts, change line/counter colors to improve clarity:

* Old Bugs will be purple ("done").

* C++26 will be blue ("accent").
Now that each chart has a single axis, we can simplify their explanations.
Move "For all lines, fewer is better." down, as it's not important.

Centralize the explanation of how features and LWG issue resolutions are regularly voted in.
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Jul 7, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner July 7, 2024 02:41
@StephanTLavavej StephanTLavavej merged commit e171096 into microsoft:gh-pages Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant