-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status Chart: Extract bugChart #4813
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old color names were removed, so we have to use the new names. Adjust `type ColorName` accordingly. 'Old Bugs' used '--color-scale-red-7', which was problematic because it didn't respond to light/dark. Replace it with the "attention" color, since it doesn't overlap with 'Skipped Libcxx Tests'. Adjust the Counter in index.html accordingly. Change the Counters in index.html for Pull Requests and Combined Age to use normal classes from Primer CSS. This results in some change for dark mode, but it's still sufficiently clear.
This updates the CSS classes in index.html to use the new names. This isn't strictly necessary right now, but it's a good idea for the future.
Drop the line "This chart has two vertical axes." This is a full-history chart, using `timeframe_idx`.
We don't need to auto-hide lines anymore, but leave the machinery implemented. Move the bugChart's largeAxis to the right. Now that we have different charts, change line/counter colors to improve clarity: * Old Bugs will be purple ("done"). * C++26 will be blue ("accent").
Now that each chart has a single axis, we can simplify their explanations.
Move "For all lines, fewer is better." down, as it's not important. Centralize the explanation of how features and LWG issue resolutions are regularly voted in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗺️ Overview
In addition to 5 weekly updates, this contains dependency updates including breaking changes in primer/css.
While dealing with those breaking changes, I lost the ability to have a dark red color. That prompted me to notice that the bugs/issues were really cluttering up the chart as our history has grown. Earlier (in #4235), we hid the lines by default to mitigate this, but with fewer colors available it was even more of a mess. So, I split out another chart, which makes everything much clearer.
📜 Commits
type ColorName
accordingly.This results in some change for dark mode, but it's still sufficiently clear.
timeframe_idx
.📉 Live preview: stephantlavavej.github.io/STL/