Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Unity URP SSAO #225

Open
anonymous2585 opened this issue Oct 31, 2024 · 1 comment · May be fixed by #226
Open

Support for Unity URP SSAO #225

anonymous2585 opened this issue Oct 31, 2024 · 1 comment · May be fixed by #226
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@anonymous2585
Copy link

Describe the problem

We use the MRTK shader for a multi platform project. We wanted to add an SSAO graphics option on powerfull platforms (PC), but the MRTK shader doesn't support it when set to "Depth Normal" mode, because some passes are missing in the shader. We were forced to use the "Depth" mode.

Describe the solution you'd like

Implementation of the Unity URP SSAO system in the shader.

Additional context

We added it locally and I will do a PR when I find the time.

Of course, don't activate URP SSAO on Hololens, it eats to much performances!

@Cameron-Micka Cameron-Micka added the bug Something isn't working label Oct 31, 2024
@Cameron-Micka
Copy link
Member

Thanks for opening this issue!

@Cameron-Micka Cameron-Micka added the good first issue Good for newcomers label Oct 31, 2024
anonymous2585 pushed a commit to anonymous2585/MixedReality-GraphicsTools-Unity that referenced this issue Nov 13, 2024
anonymous2585 pushed a commit to anonymous2585/MixedReality-GraphicsTools-Unity that referenced this issue Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
2 participants